Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hack/e2e.go #84696

Merged
merged 1 commit into from Nov 7, 2019
Merged

Remove hack/e2e.go #84696

merged 1 commit into from Nov 7, 2019

Conversation

dims
Copy link
Member

@dims dims commented Nov 4, 2019 •
edited

picking up the commit from @BenTheElder

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

removes hack/e2e.go which has been a wrapper around k8s.io/test-infra/kubetest for O(years). Please see additional context in:
#82458 (comment)

Which issue(s) this PR fixes:

Fixes #82448

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 4, 2019
@dims
Copy link
Member Author

dims commented Nov 4, 2019

/test pull-kubernetes-e2e-gce-100-performance

@dims
Copy link
Member Author

dims commented Nov 4, 2019

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 4, 2019
@dims dims changed the title [WIP] remove hack/e2e.go Remove hack/e2e.go Nov 4, 2019
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 4, 2019
@dims
Copy link
Member Author

dims commented Nov 4, 2019

/kind cleanup
/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 4, 2019
@dims
Copy link
Member Author

dims commented Nov 4, 2019

/assign @liggitt @wojtek-t

@BenTheElder
Copy link
Member

/lgtm
/approve
/hold
Thanks for picking this up!
Holding so someone else can review, not sure how much of this was originally my commit ;-)

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Nov 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2019
@liggitt
Copy link
Member

liggitt commented Nov 7, 2019

lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2019
@k8s-ci-robot k8s-ci-robot merged commit 7a1eaa1 into kubernetes:master Nov 7, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 7, 2019
@BenTheElder
Copy link
Member

BenTheElder commented Nov 7, 2019 via email

@ingvagabund ingvagabund mentioned this pull request Nov 16, 2019
Closed
kolyshkin added a commit to kolyshkin/test-infra that referenced this pull request Feb 22, 2020
@kolyshkin
kubetest/README: rm mentions of hack/e2e.go
c873da2 
Since kubernetes/kubernetes#84696
there is no longer hack/e2e.go in kubernetes repo, so let's
not mention it here.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin added a commit to kolyshkin/test-infra that referenced this pull request Feb 22, 2020
@kolyshkin
kubetest --help: fix description of --skew
8d1b174 
Since PR kubernetes/kubernetes#84696
hack/e2e.go is no longer part of kubernetes/kubernetes, so
let's not mention it here.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin kolyshkin mentioned this pull request Feb 22, 2020
Merged
@spiffxp spiffxp mentioned this pull request Jul 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@bowei bowei Awaiting requested review from bowei

Assignees

@BenTheElder BenTheElder

@liggitt liggitt

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

Deprecating and remove hack/e2e.go
5 participants
@dims @BenTheElder @k8s-ci-robot @liggitt @wojtek-t